Files
capsule/internal/webhook/pvc/pvc_mutating_volume.go
Oliver BählerandGitHub 93fafdc2fd fix: do not mutate on update and bound pvcs (#2073)
* fix: do not mutate on update and bound pvcs

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

* fix: do not mutate on update and bound pvcs

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

---------

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
2026-08-11 12:03:16 +02:00

152 lines
3.9 KiB
Go

// Copyright 2020-2026 Project Capsule Authors
// SPDX-License-Identifier: Apache-2.0
package pvc
import (
"context"
"encoding/json"
"net/http"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
capsulev1beta2 "github.com/projectcapsule/capsule/api/v1beta2"
"github.com/projectcapsule/capsule/pkg/api/meta"
"github.com/projectcapsule/capsule/pkg/runtime/events"
"github.com/projectcapsule/capsule/pkg/runtime/handlers"
)
type persistentVolumeMutatingVolume struct{}
func PersistentVolumeMutatingVolume() handlers.TypedHandlerWithTenant[*corev1.PersistentVolumeClaim] {
return &persistentVolumeMutatingVolume{}
}
func (h persistentVolumeMutatingVolume) OnCreate(
_ client.Client,
_ client.Reader,
pvc *corev1.PersistentVolumeClaim,
_ admission.Decoder,
recorder events.EventRecorder,
tnt *capsulev1beta2.Tenant,
) handlers.Func {
return func(ctx context.Context, req admission.Request) *admission.Response {
// Kubernetes does not dynamically provision PVs for PVCs with a non-empty selector.
// Therefore, only mutate PVCs that already opted into static binding semantics:
// - either by setting spec.selector
// - or by pre-binding through spec.volumeName
if pvc.Spec.Selector == nil && pvc.Spec.VolumeName == "" {
return nil
}
pvc.Spec.Selector = addTenantSelectorExpression(pvc.Spec.Selector, tnt.Name)
marshaled, err := json.Marshal(pvc)
if err != nil {
response := admission.Errored(http.StatusInternalServerError, err)
return &response
}
response := admission.PatchResponseFromRaw(req.Object.Raw, marshaled)
return &response
}
}
func (h persistentVolumeMutatingVolume) OnUpdate(
_ client.Client,
_ client.Reader,
oldPVC *corev1.PersistentVolumeClaim,
newPVC *corev1.PersistentVolumeClaim,
_ admission.Decoder,
recorder events.EventRecorder,
tnt *capsulev1beta2.Tenant,
) handlers.Func {
return func(ctx context.Context, req admission.Request) *admission.Response {
if isBoundPVC(oldPVC) {
return nil
}
if newPVC == nil || tnt == nil {
return nil
}
// Avoid mutating normal dynamically provisioned PVCs.
//
// Only canonicalize tenant selector if the PVC already participates in
// static binding semantics.
if newPVC.Spec.Selector == nil {
return nil
}
newPVC.Spec.Selector = addTenantSelectorExpression(newPVC.Spec.Selector, tnt.Name)
marshaled, err := json.Marshal(newPVC)
if err != nil {
response := admission.Errored(http.StatusInternalServerError, err)
return &response
}
response := admission.PatchResponseFromRaw(req.Object.Raw, marshaled)
return &response
}
}
func (h persistentVolumeMutatingVolume) OnDelete(
client.Client,
client.Reader,
*corev1.PersistentVolumeClaim,
admission.Decoder,
events.EventRecorder,
*capsulev1beta2.Tenant,
) handlers.Func {
return func(context.Context, admission.Request) *admission.Response {
return nil
}
}
func addTenantSelectorExpression(
selector *metav1.LabelSelector,
tenantName string,
) *metav1.LabelSelector {
if selector == nil {
selector = &metav1.LabelSelector{}
}
// Remove tenant label from MatchLabels to avoid conflicting requirements.
if selector.MatchLabels != nil {
delete(selector.MatchLabels, meta.TenantLabel)
if len(selector.MatchLabels) == 0 {
selector.MatchLabels = nil
}
}
// Remove any existing tenant expression, regardless of operator or value.
matchExpressions := make([]metav1.LabelSelectorRequirement, 0, len(selector.MatchExpressions))
for _, expression := range selector.MatchExpressions {
if expression.Key == meta.TenantLabel {
continue
}
matchExpressions = append(matchExpressions, expression)
}
matchExpressions = append(matchExpressions, metav1.LabelSelectorRequirement{
Key: meta.TenantLabel,
Operator: metav1.LabelSelectorOpIn,
Values: []string{tenantName},
})
selector.MatchExpressions = matchExpressions
return selector
}