From ede96f5cf45b972d8cfee72b7b5ca47765c24e1e Mon Sep 17 00:00:00 2001 From: Alessio Pragliola Date: Fri, 14 Oct 2022 18:42:04 +0200 Subject: [PATCH] fix: service controller not skipping sentinel errs --- controllers/servicelabels/abstract.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/controllers/servicelabels/abstract.go b/controllers/servicelabels/abstract.go index 7625184a..90b22884 100644 --- a/controllers/servicelabels/abstract.go +++ b/controllers/servicelabels/abstract.go @@ -38,7 +38,10 @@ func (r *abstractServiceLabelsReconciler) InjectClient(c client.Client) error { func (r *abstractServiceLabelsReconciler) Reconcile(ctx context.Context, request ctrl.Request) (ctrl.Result, error) { tenant, err := r.getTenant(ctx, request.NamespacedName, r.client) if err != nil { - if errors.As(err, &NonTenantObjectError{}) || errors.As(err, &NoServicesMetadataError{}) { + noTenantObjError := &NonTenantObjectError{} + noSvcMetaError := &NoServicesMetadataError{} + + if errors.As(err, &noTenantObjError) || errors.As(err, &noSvcMetaError) { return reconcile.Result{}, nil }