mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-05-26 17:33:11 +00:00
cf7e29c10d
My builds kept flaking out with errors like `invalid format delimiter 'ghadelimiter_...' not found before end of file` or just strange failures in the complete job. After some digging I found an issue in `parseEnvFile` and have tested this fix against the test case presented.
- `parseEnvFile` reads `$GITHUB_ENV` / `$GITHUB_OUTPUT` with a `bufio.Scanner` using the default 64 KiB token size, and never checks `s.Err()`.
- Any action that writes a multi-line value with a single line >64 KiB silently aborts the scan with `bufio.ErrTooLong`, which surfaces as the misleading `"invalid format delimiter
'ghadelimiter_…' not found before end of file"`.
- Real-world trigger: `docker/build-push-action`'s `metadata` output embeds the full `GITHUB_EVENT_PATH` payload via buildx provenance; a long PR description (e.g. a Renovate dependency
table) puts the body field on one JSON-escaped line well past 64 KiB.
- Raise the scanner buffer to 1 MiB so realistic outputs parse.
### Reproduction
Test this in an action. This removes the `docker/build-push-action` aspect and reproduces it directly.
```yaml
jobs:
repro:
runs-on: ubuntu-latest
steps:
- id: big
run: |
{
echo 'value<<EOF'
head -c 70000 /dev/urandom | base64 -w0
echo
echo 'EOF'
} >> "$GITHUB_OUTPUT"
```
---------
Co-authored-by: Nicolas <bircni@icloud.com>
Co-authored-by: silverwind <me@silverwind.io>
Reviewed-on: https://gitea.com/gitea/runner/pulls/974
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-by: silverwind <2021+silverwind@noreply.gitea.com>
Co-authored-by: Jacob Alberty <jacob.alberty@gmail.com>
Co-committed-by: Jacob Alberty <jacob.alberty@gmail.com>
73 lines
2.0 KiB
Go
73 lines
2.0 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Copyright 2022 The nektos/act Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package container
|
|
|
|
import (
|
|
"archive/tar"
|
|
"bufio"
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
|
|
"gitea.com/gitea/runner/act/common"
|
|
)
|
|
|
|
func parseEnvFile(e Container, srcPath string, env *map[string]string) common.Executor {
|
|
localEnv := *env
|
|
return func(ctx context.Context) error {
|
|
envTar, err := e.GetContainerArchive(ctx, srcPath)
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
defer envTar.Close()
|
|
reader := tar.NewReader(envTar)
|
|
_, err = reader.Next()
|
|
if err != nil && err != io.EOF {
|
|
return err
|
|
}
|
|
s := bufio.NewScanner(reader)
|
|
// Default 64 KiB max token size is too small for realistic env-file lines; allow up to 16 MiB.
|
|
s.Buffer(make([]byte, 0, 64*1024), 16*1024*1024)
|
|
for s.Scan() {
|
|
line := s.Text()
|
|
singleLineEnv := strings.Index(line, "=")
|
|
multiLineEnv := strings.Index(line, "<<")
|
|
if singleLineEnv != -1 && (multiLineEnv == -1 || singleLineEnv < multiLineEnv) {
|
|
localEnv[line[:singleLineEnv]] = line[singleLineEnv+1:]
|
|
} else if multiLineEnv != -1 {
|
|
multiLineEnvContent := ""
|
|
multiLineEnvDelimiter := line[multiLineEnv+2:]
|
|
delimiterFound := false
|
|
for s.Scan() {
|
|
content := s.Text()
|
|
if content == multiLineEnvDelimiter {
|
|
delimiterFound = true
|
|
break
|
|
}
|
|
if multiLineEnvContent != "" {
|
|
multiLineEnvContent += "\n"
|
|
}
|
|
multiLineEnvContent += content
|
|
}
|
|
if err := s.Err(); err != nil {
|
|
return fmt.Errorf("reading env file: %w", err)
|
|
}
|
|
if !delimiterFound {
|
|
return fmt.Errorf("invalid format delimiter '%v' not found before end of file", multiLineEnvDelimiter)
|
|
}
|
|
localEnv[line[:multiLineEnv]] = multiLineEnvContent
|
|
} else {
|
|
return fmt.Errorf("invalid format '%v', expected a line with '=' or '<<'", line)
|
|
}
|
|
}
|
|
if err := s.Err(); err != nil {
|
|
return fmt.Errorf("reading env file: %w", err)
|
|
}
|
|
env = &localEnv
|
|
return nil
|
|
}
|
|
}
|