mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-08-20 12:06:21 +00:00
silverwindandsilverwind
bc8161c673
Jobs occasionally go silent ([example](https://gitea.com/gitea/runner/actions/runs/805045/jobs/1055123)) mid-run and Gitea reaped them after `ZOMBIE_TASK_TIMEOUT`, with no error in the log. This contains a number of related fixes, all with full test coverage: 1. Bound every RPC to Gitea with a timeout, a stalled report otherwise parked logs and heartbeats for the whole job. 2. Cap `runner.fetch_timeout` at that ceiling. 3. Let only the daemon loop close its own channel, the race panicked the process. 4. Stop the job on any terminal server result, not just `RESULT_CANCELLED`. 5. Report that result instead of relabelling it as cancelled. 6. Log reporting failures once at each end of an outage instead of discarding them. 7. Clamp the acknowledged log index, a too-large ack panicked on a slice bound. 8. Stop reading server health from a `FetchTask` deadline, it marked the runner healthy and reset the error backoff on a timeout. 9. Return an error from the Docker version probe instead of a `logrus` panic. 10. Pass the context to go-git's fetch and pull. 11. Fail the clone when a refresh dies on a cancelled context. 12. Set `terminationGracePeriodSeconds` in the Kubernetes examples. Also contains a deprecation fix for goreleaser. Reviewed-on: https://gitea.com/gitea/runner/pulls/1174 Reviewed-by: bircni <bircni@icloud.com> Co-authored-by: silverwind <me@silverwind.io>
98 lines
3.1 KiB
Go
98 lines
3.1 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package client
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"connectrpc.com/connect"
|
|
pingv1 "gitea.dev/actionslib/ping/v1"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGetHTTPClientUsesProxyFromEnvironment(t *testing.T) {
|
|
t.Setenv("HTTP_PROXY", "http://proxy.example.com:8080")
|
|
|
|
client := getHTTPClient("http://gitea.example.com", false, time.Minute)
|
|
require.Equal(t, time.Minute, client.Timeout)
|
|
transport, ok := client.Transport.(*http.Transport)
|
|
require.True(t, ok)
|
|
|
|
req, err := http.NewRequest(http.MethodGet, "http://gitea.example.com/api/actions/ping", nil)
|
|
require.NoError(t, err)
|
|
|
|
proxyURL, err := transport.Proxy(req)
|
|
require.NoError(t, err)
|
|
require.NotNil(t, proxyURL)
|
|
require.Equal(t, "http://proxy.example.com:8080", proxyURL.String())
|
|
}
|
|
|
|
func TestGetHTTPClientInsecureTLS(t *testing.T) {
|
|
// insecure only takes effect for https endpoints
|
|
httpsInsecure := getHTTPClient("https://gitea.example.com", true, time.Minute)
|
|
transport, ok := httpsInsecure.Transport.(*http.Transport)
|
|
require.True(t, ok)
|
|
require.NotNil(t, transport.TLSClientConfig)
|
|
require.True(t, transport.TLSClientConfig.InsecureSkipVerify)
|
|
|
|
for _, tc := range []struct {
|
|
name string
|
|
endpoint string
|
|
insecure bool
|
|
}{
|
|
{"https secure", "https://gitea.example.com", false},
|
|
{"http insecure ignored", "http://gitea.example.com", true},
|
|
} {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
c := getHTTPClient(tc.endpoint, tc.insecure, time.Minute)
|
|
tr, ok := c.Transport.(*http.Transport)
|
|
require.True(t, ok)
|
|
require.Nil(t, tr.TLSClientConfig)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewSetsBaseURLAndHeaders(t *testing.T) {
|
|
var gotPath string
|
|
gotHeaders := make(http.Header)
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
gotPath = r.URL.Path
|
|
gotHeaders = r.Header.Clone()
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
}))
|
|
defer server.Close()
|
|
|
|
// trailing slash must be trimmed before "/api/actions" is appended
|
|
c := New(server.URL+"/", false, "the-uuid", "the-token", time.Minute)
|
|
// Address returns the endpoint as supplied (untrimmed)
|
|
require.Equal(t, server.URL+"/", c.Address())
|
|
require.False(t, c.Insecure())
|
|
|
|
// the call is expected to fail (server returns 500), we only assert what was sent
|
|
_, _ = c.Ping(t.Context(), connect.NewRequest(&pingv1.PingRequest{Data: "hi"}))
|
|
|
|
require.True(t, strings.HasPrefix(gotPath, "/api/actions/"), "unexpected path %q", gotPath)
|
|
require.Equal(t, "the-uuid", gotHeaders.Get(UUIDHeader))
|
|
require.Equal(t, "the-token", gotHeaders.Get(TokenHeader))
|
|
}
|
|
|
|
func TestNewOmitsEmptyHeaders(t *testing.T) {
|
|
gotHeaders := make(http.Header)
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
gotHeaders = r.Header.Clone()
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
}))
|
|
defer server.Close()
|
|
|
|
c := New(server.URL, false, "", "", time.Minute)
|
|
_, _ = c.Ping(t.Context(), connect.NewRequest(&pingv1.PingRequest{Data: "hi"}))
|
|
|
|
require.Empty(t, gotHeaders.Get(UUIDHeader))
|
|
require.Empty(t, gotHeaders.Get(TokenHeader))
|
|
}
|