mirror of
https://github.com/stakater/Reloader.git
synced 2026-08-20 12:36:26 +00:00
Nikolaus Schuetz
20220ed7ef
The alert send functions (Slack/Teams/GChat/raw) return `[]error`, but `SendWebhookAlert` discarded them, so a failing webhook — e.g. a Teams alert returning a non-2xx status — produced no output at all, even at trace level (#949). Capture the returned errors and log each with `logrus.Errorf`, as suggested by the maintainer on the issue. Adds a regression test that drives a failing (500) webhook and asserts the error is logged. Closes #949 Assisted-by: Claude Code (Anthropic, Opus 4.x)
41 lines
1.1 KiB
Go
41 lines
1.1 KiB
Go
package alert
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
logrustest "github.com/sirupsen/logrus/hooks/test"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// TestSendWebhookAlert_LogsSendErrors is a regression test for #949: a failing
|
|
// webhook (here, a non-2xx response) previously produced no output at all
|
|
// because the errors returned by the send functions were discarded. They must
|
|
// now be surfaced as error logs.
|
|
func TestSendWebhookAlert_LogsSendErrors(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
}))
|
|
defer server.Close()
|
|
|
|
hook := logrustest.NewGlobal()
|
|
defer hook.Reset()
|
|
|
|
t.Setenv("ALERT_WEBHOOK_URL", server.URL)
|
|
t.Setenv("ALERT_SINK", string(AlertSinkTeams))
|
|
|
|
SendWebhookAlert("test message")
|
|
|
|
var logged bool
|
|
for _, entry := range hook.AllEntries() {
|
|
if entry.Level == logrus.ErrorLevel && strings.Contains(entry.Message, "Error sending alert") {
|
|
logged = true
|
|
break
|
|
}
|
|
}
|
|
assert.True(t, logged, "expected the swallowed webhook error to be logged")
|
|
}
|