From faf27c2d5d04d8097b288dc8f6569a340ea4593e Mon Sep 17 00:00:00 2001
From: faizanahmad055 <faizan.ahmad55@outlook.com>
Date: Mon, 19 Oct 2020 16:00:54 +0200
Subject: [PATCH] Add support for legacy rbac

Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
---
 README.md                                                  | 7 +++++++
 .../kubernetes/chart/reloader/templates/clusterrole.yaml   | 4 ++++
 .../chart/reloader/templates/clusterrolebinding.yaml       | 4 ++++
 deployments/kubernetes/chart/reloader/templates/role.yaml  | 4 ++++
 .../kubernetes/chart/reloader/templates/rolebinding.yaml   | 4 ++++
 deployments/kubernetes/chart/reloader/values.yaml          | 2 ++
 6 files changed, 25 insertions(+)

diff --git a/README.md b/README.md
index a41c25fd..0c4b1d9d 100644
--- a/README.md
+++ b/README.md
@@ -22,6 +22,7 @@ Reloader can watch changes in `ConfigMap` and `Secret` and do rolling upgrades o
 ## Compatibility
 
 Reloader is compatible with kubernetes >= 1.9
+The `apiVersion: rbac.authorization.k8s.io/v1beta1` is depreciated since kubernetes = 1.17. To run it with older versions, please use the chart parameter `reloader.legacy.rbac=true`
 
 ## How to use Reloader
 
@@ -201,6 +202,12 @@ helm repo update
 helm install stakater/reloader
 ```
 
+**Note:** The latest verion of reloader is using `apiVersion: rbac.authorization.k8s.io/v1` for rbac. The `apiVersion: rbac.authorization.k8s.io/v1beta1` is depreciated since kubernetes = 1.17. To run it with older versions, please use below command.
+
+```bash
+helm install stakater/reloader --set reloader.legacy.rbac=true
+```
+
 **Note:** By default reloader watches in all namespaces. To watch in single namespace, please run following command. It will install reloader in `test` namespace which will only watch `Deployments`, `Daemonsets` and `Statefulsets` in `test` namespace.
 
 ```bash
diff --git a/deployments/kubernetes/chart/reloader/templates/clusterrole.yaml b/deployments/kubernetes/chart/reloader/templates/clusterrole.yaml
index 8b5b451d..db523393 100644
--- a/deployments/kubernetes/chart/reloader/templates/clusterrole.yaml
+++ b/deployments/kubernetes/chart/reloader/templates/clusterrole.yaml
@@ -1,5 +1,9 @@
 {{- if and .Values.reloader.watchGlobally (.Values.reloader.rbac.enabled) }}
+{{- if and .Values.reloader.legacy.rbac }}
+apiVersion: rbac.authorization.k8s.io/v1beta1
+{{ else }}
 apiVersion: rbac.authorization.k8s.io/v1
+{{- end }}
 kind: ClusterRole
 metadata:
   labels:
diff --git a/deployments/kubernetes/chart/reloader/templates/clusterrolebinding.yaml b/deployments/kubernetes/chart/reloader/templates/clusterrolebinding.yaml
index 8a2e0150..65d5f921 100644
--- a/deployments/kubernetes/chart/reloader/templates/clusterrolebinding.yaml
+++ b/deployments/kubernetes/chart/reloader/templates/clusterrolebinding.yaml
@@ -1,5 +1,9 @@
 {{- if and .Values.reloader.watchGlobally (.Values.reloader.rbac.enabled) }}
+{{- if and .Values.reloader.legacy.rbac }}
+apiVersion: rbac.authorization.k8s.io/v1beta1
+{{ else }}
 apiVersion: rbac.authorization.k8s.io/v1
+{{- end }}
 kind: ClusterRoleBinding
 metadata:
   labels:
diff --git a/deployments/kubernetes/chart/reloader/templates/role.yaml b/deployments/kubernetes/chart/reloader/templates/role.yaml
index cbd59794..68263d65 100644
--- a/deployments/kubernetes/chart/reloader/templates/role.yaml
+++ b/deployments/kubernetes/chart/reloader/templates/role.yaml
@@ -1,5 +1,9 @@
 {{- if and (not (.Values.reloader.watchGlobally)) (.Values.reloader.rbac.enabled) }}
+{{- if and .Values.reloader.legacy.rbac }}
+apiVersion: rbac.authorization.k8s.io/v1beta1
+{{ else }}
 apiVersion: rbac.authorization.k8s.io/v1
+{{- end }}
 kind: Role
 metadata:
   labels:
diff --git a/deployments/kubernetes/chart/reloader/templates/rolebinding.yaml b/deployments/kubernetes/chart/reloader/templates/rolebinding.yaml
index 08868f0e..a7d27284 100644
--- a/deployments/kubernetes/chart/reloader/templates/rolebinding.yaml
+++ b/deployments/kubernetes/chart/reloader/templates/rolebinding.yaml
@@ -1,5 +1,9 @@
 {{- if and (not (.Values.reloader.watchGlobally)) (.Values.reloader.rbac.enabled) }}
+{{- if and .Values.reloader.legacy.rbac }}
+apiVersion: rbac.authorization.k8s.io/v1beta1
+{{ else }}
 apiVersion: rbac.authorization.k8s.io/v1
+{{- end }}
 kind: RoleBinding
 metadata:
   labels: 
diff --git a/deployments/kubernetes/chart/reloader/values.yaml b/deployments/kubernetes/chart/reloader/values.yaml
index b37c5f51..756f52b2 100644
--- a/deployments/kubernetes/chart/reloader/values.yaml
+++ b/deployments/kubernetes/chart/reloader/values.yaml
@@ -17,6 +17,8 @@ reloader:
   watchGlobally: true
   # Set to true if you have a pod security policy that enforces readOnlyRootFilesystem
   readOnlyRootFileSystem: false
+  legacy:
+    rbac: false
   matchLabels: {}
   deployment:
     nodeSelector: