From f7927c85b1468fbec0551d5327ff8a98bad0ed89 Mon Sep 17 00:00:00 2001 From: Henno Schooljan Date: Fri, 25 Jun 2021 21:28:16 +0200 Subject: [PATCH] Disable OpenShift by default, add notes in README. --- README.md | 7 +++++++ .../kubernetes/chart/reloader/templates/clusterrole.yaml | 2 +- deployments/kubernetes/chart/reloader/templates/role.yaml | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b58abf05..9d098834 100644 --- a/README.md +++ b/README.md @@ -221,6 +221,13 @@ You can also set the log format of Reloader to json by setting `logFormat` to `j You can enable to scrape Reloader's Prometheus metrics by setting `serviceMonitor.enabled` or `podMonitor.enabled` to `true` in values.yaml file. Service monitor will be removed in future releases of reloader in favour of Pod monitor. +**Note:** Reloading of OpenShift (DeploymentConfig) and/or Argo Rollouts has to be enabled explicitly because it might not be always possible to use it on a cluster with restricted permissions. This can be done by changing the following parameters: + +| Parameter | Description | Type | +| ---------------- | ---------------------------------------------------------------------------- | ------- | +| isOpenshift | Enable OpenShift DeploymentConfigs. Valid value are either `true` or `false` | boolean | +| isArgoRollouts | Enable Argo Rollouts. Valid value are either `true` or `false` | boolean | + ## Help ### Documentation diff --git a/deployments/kubernetes/chart/reloader/templates/clusterrole.yaml b/deployments/kubernetes/chart/reloader/templates/clusterrole.yaml index aee84adc..c88f8bb5 100644 --- a/deployments/kubernetes/chart/reloader/templates/clusterrole.yaml +++ b/deployments/kubernetes/chart/reloader/templates/clusterrole.yaml @@ -32,7 +32,7 @@ rules: - list - get - watch -{{- if or (.Capabilities.APIVersions.Has "apps.openshift.io/v1") (.Values.reloader.isOpenshift) }} +{{- if and (.Capabilities.APIVersions.Has "apps.openshift.io/v1") (.Values.reloader.isOpenshift) }} - apiGroups: - "apps.openshift.io" - "" diff --git a/deployments/kubernetes/chart/reloader/templates/role.yaml b/deployments/kubernetes/chart/reloader/templates/role.yaml index 4fe58636..0a8d5184 100644 --- a/deployments/kubernetes/chart/reloader/templates/role.yaml +++ b/deployments/kubernetes/chart/reloader/templates/role.yaml @@ -32,7 +32,7 @@ rules: - list - get - watch -{{- if or (.Capabilities.APIVersions.Has "apps.openshift.io/v1") (.Values.reloader.isOpenshift) }} +{{- if and (.Capabilities.APIVersions.Has "apps.openshift.io/v1") (.Values.reloader.isOpenshift) }} - apiGroups: - "apps.openshift.io" - ""