comments resolved

.github/workflows/pull_request.yaml

@@ -62,6 +62,7 @@ jobs:
         go-version-file: 'go.mod'
         check-latest: true
         cache: true
+
     - name: Create timestamp
       id: prep
       run: echo "created=$(date -u +'%Y-%m-%dT%H:%M:%SZ')" >> $GITHUB_OUTPUT

Dockerfile

@@ -13,7 +13,6 @@ ARG COMMIT
 ARG VERSION
 ARG BUILD_DATE
 
-
 WORKDIR /workspace
 
 # Copy the Go Modules manifests

deployments/kubernetes/chart/reloader/templates/role.yaml

@@ -105,11 +105,7 @@ rules:
 ---
 
 {{- if .Values.reloader.rbac.enabled }}
-{{- if  (.Capabilities.APIVersions.Has "rbac.authorization.k8s.io/v1") }}
 apiVersion: rbac.authorization.k8s.io/v1
-{{ else }}
-apiVersion: rbac.authorization.k8s.io/v1beta1
-{{- end }}
 kind: Role
 metadata:
   annotations:

deployments/kubernetes/chart/reloader/templates/rolebinding.yaml

@@ -30,11 +30,7 @@ subjects:
 
 ---
 {{- if .Values.reloader.rbac.enabled }}
-{{- if  (.Capabilities.APIVersions.Has "rbac.authorization.k8s.io/v1") }}
 apiVersion: rbac.authorization.k8s.io/v1
-{{ else }}
-apiVersion: rbac.authorization.k8s.io/v1beta1
-{{- end }}
 kind: RoleBinding
 metadata:
   annotations:

deployments/kubernetes/kustomization.yaml

@@ -6,3 +6,4 @@ resources:
   - manifests/clusterrolebinding.yaml
   - manifests/serviceaccount.yaml
   - manifests/deployment.yaml
+  - manifests/role.yaml

deployments/kubernetes/manifests/deployment.yaml

@@ -31,6 +31,13 @@ spec:
                 resourceFieldRef:
                   resource: limits.memory
                   divisor: '1'
+            - name: RELOADER_NAMESPACE
+              valueFrom:
+                fieldRef:
+                  fieldPath: metadata.namespace
+
+            - name: RELOADER_DEPLOYMENT_NAME
+              value: reloader-reloader
           ports:
             - name: http
               containerPort: 9090

deployments/kubernetes/manifests/role.yaml

@@ -0,0 +1,32 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: Role
+metadata:
+  name: reloader-reloader-metadata-role
+  namespace: default
+rules:
+  - apiGroups:
+      - ""
+    resources:
+      - configmaps
+    verbs:
+      - list
+      - get
+      - watch
+      - create
+      - update
+
+---
+
+apiVersion: rbac.authorization.k8s.io/v1
+kind: RoleBinding
+metadata:
+  name: reloader-reloader-metadata-rolebinding
+  namespace: default
+subjects:
+  - kind: ServiceAccount
+    name: reloader-reloader
+    namespace: default
+roleRef:
+  kind: Role
+  name: reloader-reloader-metadata-role
+  apiGroup: rbac.authorization.k8s.io

deployments/kubernetes/reloader.yaml

@@ -5,6 +5,23 @@ metadata:
   namespace: default
 ---
 apiVersion: rbac.authorization.k8s.io/v1
+kind: Role
+metadata:
+  name: reloader-reloader-metadata-role
+  namespace: default
+rules:
+- apiGroups:
+  - ""
+  resources:
+  - configmaps
+  verbs:
+  - list
+  - get
+  - watch
+  - create
+  - update
+---
+apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   name: reloader-reloader-role
@@ -64,6 +81,20 @@ rules:
   - patch
 ---
 apiVersion: rbac.authorization.k8s.io/v1
+kind: RoleBinding
+metadata:
+  name: reloader-reloader-metadata-rolebinding
+  namespace: default
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: Role
+  name: reloader-reloader-metadata-role
+subjects:
+- kind: ServiceAccount
+  name: reloader-reloader
+  namespace: default
+---
+apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   name: reloader-reloader-role-binding
@@ -76,37 +107,6 @@ subjects:
   name: reloader-reloader
   namespace: default
 ---
-apiVersion: rbac.authorization.k8s.io/v1
-kind: Role
-metadata:
-  name: reloader-metadata-role
-  namespace: default
-rules:
-  - apiGroups:
-      - ""
-    resources:
-      - configmaps
-    verbs:
-      - list
-      - get
-      - watch
-      - create
-      - update
----
-apiVersion: rbac.authorization.k8s.io/v1
-kind: RoleBinding
-metadata:
-  name: reloader-metadata-role-binding
-  namespace: default
-roleRef:
-  apiGroup: rbac.authorization.k8s.io
-  kind: Role
-  name: reloader-metadata-role
-subjects:
-  - kind: ServiceAccount
-    name: reloader-reloader
-    namespace: default
----
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -139,11 +139,9 @@ spec:
           valueFrom:
             fieldRef:
               fieldPath: metadata.namespace
-        
         - name: RELOADER_DEPLOYMENT_NAME
-          value: default
-              
-        image: "ghcr.io/stakater/reloader:latest"
+          value: reloader-reloader
+        image: ghcr.io/stakater/reloader:test-image
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 5