feat: golangci-lint config and fixes

deployments/kubernetes/chart/reloader/templates/clusterrole.yaml

@@ -56,12 +56,12 @@ rules:
 {{- if and (.Capabilities.APIVersions.Has "argoproj.io/v1alpha1") (.Values.reloader.isArgoRollouts) }}
   - apiGroups:
       - "argoproj.io"
-      - ""
     resources:
       - rollouts
     verbs:
       - list
       - get
+      - watch
       - update
       - patch
 {{- end }}
@@ -85,6 +85,9 @@ rules:
     verbs:
       - list
       - get
+      - watch
+      - update
+      - patch
 {{- end }}
 {{- if .Values.reloader.ignoreJobs }}{{- else }}
   - apiGroups:
@@ -96,6 +99,7 @@ rules:
       - delete
       - list
       - get
+      - watch
 {{- end}}
 {{- if .Values.reloader.enableHA }}
   - apiGroups:

deployments/kubernetes/chart/reloader/templates/deployment.yaml

@@ -173,10 +173,12 @@ spec:
         ports:
         - name: http
           containerPort: 9090
+        - name: health
+          containerPort: 8080
         livenessProbe:
           httpGet:
-            path: /live
-            port: http
+            path: /healthz
+            port: health
           timeoutSeconds: {{ .Values.reloader.deployment.livenessProbe.timeoutSeconds | default "5" }}
           failureThreshold: {{ .Values.reloader.deployment.livenessProbe.failureThreshold | default "5" }}
           periodSeconds: {{ .Values.reloader.deployment.livenessProbe.periodSeconds | default "10" }}
@@ -184,8 +186,8 @@ spec:
           initialDelaySeconds: {{ .Values.reloader.deployment.livenessProbe.initialDelaySeconds | default "10" }}
         readinessProbe:
           httpGet:
-            path: /metrics
-            port: http
+            path: /readyz
+            port: health
           timeoutSeconds: {{ .Values.reloader.deployment.readinessProbe.timeoutSeconds | default "5" }}
           failureThreshold: {{ .Values.reloader.deployment.readinessProbe.failureThreshold | default "5" }}
           periodSeconds: {{ .Values.reloader.deployment.readinessProbe.periodSeconds | default "10" }}
@@ -235,7 +237,7 @@ spec:
           - "--namespaces-to-ignore={{ .Values.reloader.ignoreNamespaces }}"
           {{- end }}
           {{- if (include "reloader-namespaceSelector" .) }}
-          - "--namespace-selector=\"{{ include "reloader-namespaceSelector" . }}\""
+          - "--namespace-selector={{ include "reloader-namespaceSelector" . }}"
           {{- end }}
           {{- if .Values.reloader.resourceLabelSelector }}
           - "--resource-label-selector={{ .Values.reloader.resourceLabelSelector }}"

deployments/kubernetes/chart/reloader/templates/role.yaml

@@ -47,12 +47,12 @@ rules:
 {{- if and (.Capabilities.APIVersions.Has "argoproj.io/v1alpha1") (.Values.reloader.isArgoRollouts) }}
   - apiGroups:
       - "argoproj.io"
-      - ""
     resources:
       - rollouts
     verbs:
       - list
       - get
+      - watch
       - update
       - patch
 {{- end }}
@@ -75,6 +75,9 @@ rules:
     verbs:
       - list
       - get
+      - watch
+      - update
+      - patch
   - apiGroups:
       - "batch"
     resources:
@@ -84,6 +87,7 @@ rules:
       - delete
       - list
       - get
+      - watch
 {{- if .Values.reloader.enableHA }}
   - apiGroups:
       - "coordination.k8s.io"