From 2e68364298abc3f23dbd9bea47948ad7291fe001 Mon Sep 17 00:00:00 2001
From: Kunj Bosamia <135578521+kunj-bosamia@users.noreply.github.com>
Date: Fri, 21 Jun 2024 19:15:24 +0530
Subject: [PATCH] [ENHANCE] #639 , Add resources to the Reloader deployment.  
 (#692)

* issue-639 , adding Resources to the values.yaml

* revert old change

* adding resources in helm template command

* add resources to  reloader.yaml file only

* Update readme about the default resource limit and request values

* fix lint error

* fix lint error
---
 .github/workflows/push.yaml |  7 ++++++-
 README.md                   | 12 +++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml
index 82f32f4..2873cf8 100644
--- a/.github/workflows/push.yaml
+++ b/.github/workflows/push.yaml
@@ -211,7 +211,12 @@ jobs:
 
       - name: Helm Template
         run: |
-          helm template reloader deployments/kubernetes/chart/reloader/ > deployments/kubernetes/reloader.yaml
+          helm template reloader deployments/kubernetes/chart/reloader/ \
+            --set reloader.deployment.resources.limits.cpu=150m \
+            --set reloader.deployment.resources.limits.memory=512Mi \
+            --set reloader.deployment.resources.requests.cpu=10m \
+            --set reloader.deployment.resources.requests.memory=128Mi > deployments/kubernetes/reloader.yaml
+          
           helm template reloader deployments/kubernetes/chart/reloader/ --output-dir deployments/kubernetes/manifests && mv deployments/kubernetes/manifests/reloader/templates/* deployments/kubernetes/manifests/ && rm -r deployments/kubernetes/manifests/reloader
 
       - name: Remove labels and annotations from manifests
diff --git a/README.md b/README.md
index 7c4a3ed..d325427 100644
--- a/README.md
+++ b/README.md
@@ -190,7 +190,17 @@ You can apply vanilla manifests by changing `RELEASE-NAME` placeholder provided
 kubectl apply -f https://raw.githubusercontent.com/stakater/Reloader/master/deployments/kubernetes/reloader.yaml
 ```
 
-By default, Reloader gets deployed in `default` namespace and watches changes `secrets` and `configmaps` in all namespaces.
+By default, Reloader gets deployed in `default` namespace and watches changes `secrets` and `configmaps` in all namespaces.Additionally, in the default Reloader deployment, the following resource limits and requests are set:
+
+```yaml
+resources:
+  limits:
+    cpu: 150m
+    memory: 512Mi
+  requests:
+    cpu: 10m
+    memory: 128Mi
+```
 
 Reloader can be configured to ignore the resources `secrets` and `configmaps` by passing the following arguments (`spec.template.spec.containers.args`) to its container :