Tobias GesellchenandClaude Opus 5 c2591f7aa5 fix(setup): ignore cleared preset slots in the readiness comparison ...

Clearing a slot through the Marge API leaves a zero-value entry in the list
(RemovePreset assigns models.ServicePreset{}), which savePresetsNoLock
persists as <preset id=""> with no filtering. Reading it back gives an empty
slot, while mapPresetsToFullResponse drops it from the rendered /full.

The comparison then refused migration with either "contains a preset without
a slot" or a count mismatch, for a datastore that was otherwise perfectly in
sync, and Data Sync could not fix it because nothing was actually wrong.

An empty slot carries no identity to compare, so skip it on both sides.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-09-05 21:55:20 +02:00

..

testdata

fix(setup): atomic CA-bundle install with PEM-frame verification

2026-05-15 15:05:41 +02:00

build_https_url_test.go

feat(service): validate server_url and surface resolved DNS intercept IP

2026-05-14 14:49:23 +02:00

ca_validation_test.go

docs(setup): record ST10 ≡ ST20 bundle equivalence + curl reproducer

2026-05-16 16:23:23 +02:00

ca_validation.go

fix(setup): atomic CA-bundle install with PEM-frame verification

2026-05-15 15:05:41 +02:00

device_info_parsing_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

enable_ssh_test.go

fix(setup,admin-ui,install): three bugs from #621 follow-up feedback

2026-08-17 19:57:02 +02:00

enable_ssh.go

fix(setup,admin-ui,install): three bugs from #621 follow-up feedback

2026-08-17 19:57:02 +02:00

factory_reset_test.go

feat(setup): add CLI setup command group for end-to-end speaker provisioning

2026-05-13 18:43:36 +02:00

factory_reset.go

feat(setup): add CLI setup command group for end-to-end speaker provisioning

2026-05-13 18:43:36 +02:00

init_plan_test.go

feat(client): add capability-driven device settings

2026-09-05 13:32:57 +02:00

init_plan.go

feat(client): add capability-driven device settings

2026-09-05 13:32:57 +02:00

inspect_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

inspect.go

feat(setup): add CLI setup command group for end-to-end speaker provisioning

2026-05-13 18:43:36 +02:00

issue218_regression_test.go

test(fakespeaker): wire issue-specific payloads via Config.FixtureOverrides

2026-05-15 14:13:24 +02:00

issue234_regression_test.go

fix(setup): require confirmation before Sync would shrink stored data

2026-08-23 14:19:40 +02:00

issue235_regression_test.go

test(setup): wire issue #235 — Spotify Connect /now_playing reports IsPresetable=false

2026-05-15 14:13:24 +02:00

logutil.go

fix(lint): sec6/sec7 post-pass — static.go Close + remove unused sanitizeErr

2026-05-25 11:28:26 +02:00

marge_pairing_test.go

fix(setup): accept non-numeric account IDs reported by third-party pairing tools (#634)

2026-08-22 11:31:08 +02:00

marge_pairing.go

fix(setup): accept non-numeric account IDs reported by third-party pairing tools (#634)

2026-08-22 11:31:08 +02:00

migration_readiness_test.go

fix(setup): ignore cleared preset slots in the readiness comparison

2026-09-05 21:55:20 +02:00

migration_readiness.go

fix(setup): ignore cleared preset slots in the readiness comparison

2026-09-05 21:55:20 +02:00

migration_state_telnet_test.go

fix(setup): correct false-positive migration detection and plan command errors

2026-05-22 18:58:57 +02:00

migration_summary_telnet_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

peer_probe_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

peer_probe.go

feat(service): add passive peer-reachability probe handler

2026-05-11 20:31:24 +02:00

preflight_crosscheck_test.go

feat(service): capture speaker redirect config in diagnostic export

2026-05-31 12:56:45 +02:00

preflight_crosscheck.go

feat(service): capture speaker redirect config in diagnostic export

2026-05-31 12:56:45 +02:00

reboot_test.go

feat(telnet): add port-17000 migration method and account pairing

2026-05-10 12:43:36 +02:00

setup_session_test.go

feat(client): add capability-driven device settings

2026-09-05 13:32:57 +02:00

setup_session.go

feat(client): add capability-driven device settings

2026-09-05 13:32:57 +02:00

setup_test.go

fix(setup): verify account data before migration

2026-09-05 21:55:20 +02:00

setup.go

fix(setup): warn about a shared account instead of refusing migration

2026-09-05 21:55:20 +02:00

ssh_probe_apply.go

refactor(setup): split high-complexity functions into per-axis helpers

2026-05-13 18:43:36 +02:00

ssh_probe.go

feat(health): add speaker_ca_bundle integrity check

2026-05-27 01:25:56 +02:00

sync_destructive_guard_test.go

fix(setup): require confirmation before Sync would shrink stored data

2026-08-23 14:19:40 +02:00

sync_deviceid_test.go

fix(setup): require confirmation before Sync would shrink stored data

2026-08-23 14:19:40 +02:00

sync_regression_test.go

fix(setup): require confirmation before Sync would shrink stored data

2026-08-23 14:19:40 +02:00

telnet_migration_test.go

docs+fix(telnet): label getpdo output as runtime-layer-only, not proof of persistence

2026-08-09 20:46:51 +02:00

telnet_migration.go

docs+fix(telnet): label getpdo output as runtime-layer-only, not proof of persistence

2026-08-09 20:46:51 +02:00

telnet_preflight_test.go

feat(setup): read-only telnet preflight populating MigrationSummary

2026-05-11 00:37:11 +02:00

telnet_preflight.go

feat(setup): read-only telnet preflight populating MigrationSummary

2026-05-11 00:37:11 +02:00

telnet_urls_test.go

style(setup): satisfy govet shadow + thelper lints

2026-05-11 00:37:11 +02:00

url_overrides_test.go

feat(setup): XML migration honors per-field URL overrides

2026-05-11 00:37:11 +02:00

wifi_provision_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

wifi_provision.go

fix(cli): retry wifi-push once when the speaker's first ACK times out

2026-05-16 12:14:18 +02:00