Tobias GesellchenandClaude Opus 4.7 a1ae10650f style(setup): address actionable golangci-lint findings ...

Fixes the lint hits that pointed at real bugs or dead code; leaves the
remaining style-only suggestions (rangeValCopy micro-copies, gocyclo
informational, intentional name choices like SetupStateMachine) alone.

- pkg/models/clockdisplay.go: restore <clockDisplay> XMLName tag on both
  ClockDisplay and ClockDisplayRequest. The earlier `xml:"-"` clashed
  with ClockDisplayUpdatedEvent.ClockDisplay's `xml:"clockDisplay"` tag
  (SA5008). Custom MarshalXML/UnmarshalXML still own the wire format.
- pkg/service/setup/setup.go: drop the now-unused checkRemoteServices
  helper (replaced by applyProbeToSummary) and rename the unused
  deviceIP parameter of populatePlannedNetworkConfig to _.
- pkg/service/setup/setup_session.go: collapse sendStep's (string, error)
  return to plain error — every caller already discarded the string.
- pkg/service/setup/init_plan.go: rename shadowed err variables to
  rwErr / genErr / invalidErr / nilErr / stepErr.
- cmd/soundtouch-cli/cmd_setup.go: drop redundant int(syscall.Stdin)
  conversion (already int) and rename a shadowed err to pairErr.

go build ./..., go vet ./..., and tests for the touched packages all
green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-13 18:43:36 +02:00

..

account_test.go

feat: implement comprehensive music service account management with full golangci-lint compliance

2026-02-02 17:44:26 +01:00

account.go

feat: add Amazon Music management handlers and CLI wiring

2026-04-29 20:30:06 +02:00

audio_test.go

Fix golangci-lint findings and improve code quality

2026-01-11 00:39:58 +01:00

audio.go

Fix golangci-lint findings and improve code quality

2026-01-11 00:39:58 +01:00

balance_marshal_test.go

apply/fix golangci-lint findings

2026-01-10 11:43:48 +01:00

balance_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

balance.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

bass_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

bass_utilities_test.go

apply/fix golangci-lint findings

2026-01-10 11:43:48 +01:00

bass.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

capabilities.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

clockdisplay_test.go

feat(setup): add CLI setup command group for end-to-end speaker provisioning

2026-05-13 18:43:36 +02:00

clockdisplay.go

style(setup): address actionable golangci-lint findings

2026-05-13 18:43:36 +02:00

clocktime_test.go

feat(setup): add CLI setup command group for end-to-end speaker provisioning

2026-05-13 18:43:36 +02:00

clocktime.go

feat(setup): add CLI setup command group for end-to-end speaker provisioning

2026-05-13 18:43:36 +02:00

device_info_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

device.go

feat(spotify): improve Spotify registration flow and speaker notification

2026-04-06 22:39:30 +02:00

doc.go

fix: correct API method names and field references in examples

2026-01-10 12:17:39 +01:00

group.go

feat(group): add ST-10 stereo-pair support end-to-end

2026-05-11 23:18:08 +02:00

introspect_test.go

feat: implement comprehensive music service account management with full golangci-lint compliance

2026-02-02 17:44:26 +01:00

introspect.go

feat: implement comprehensive music service account management with full golangci-lint compliance

2026-02-02 17:44:26 +01:00

key_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

key.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

models.go

Fix/beautify the account overview

2026-04-23 22:08:54 +02:00

name.go

Implement /name, /capabilities, and /presets informational endpoints

2026-01-08 23:32:18 +01:00

navigation_test.go

style: apply golangci-lint --fix for all remaining issues

2026-02-01 22:11:12 +01:00

navigation.go

style: apply golangci-lint --fix for all remaining issues

2026-02-01 22:11:12 +01:00

networkinfo_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

networkinfo.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

nowplaying_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

nowplaying.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

presets.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

recents_test.go

feat: implement comprehensive music service account management with full golangci-lint compliance

2026-02-02 17:44:26 +01:00

recents.go

feat: implement comprehensive music service account management with full golangci-lint compliance

2026-02-02 17:44:26 +01:00

service_recent_parity_test.go

Add/improve e2e test cases

2026-04-04 18:53:59 +02:00

serviceavailability_test.go

style: apply golangci-lint --fix for all remaining issues

2026-02-01 22:11:12 +01:00

serviceavailability.go

style: apply golangci-lint --fix for all remaining issues

2026-02-01 22:11:12 +01:00

sources_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

sources.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

speaker_test.go

Simplify the PlayTTS method cmd

2026-02-19 08:46:55 +01:00

speaker.go

Simplify the PlayTTS method cmd

2026-02-19 08:46:55 +01:00

supportedurls.go

style: apply golangci-lint --fix for all remaining issues

2026-02-01 22:11:12 +01:00

token_test.go

Implement /requestToken API and fix clock time display

2026-01-11 23:09:29 +01:00

token.go

Implement /requestToken API and fix clock time display

2026-01-11 23:09:29 +01:00

volume_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

volume.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

websocket_test.go

feat(group): add ST-10 stereo-pair support end-to-end

2026-05-11 23:18:08 +02:00

websocket.go

feat(group): add ST-10 stereo-pair support end-to-end

2026-05-11 23:18:08 +02:00

zone_slave_test.go

Fix golangci-lint findings and improve code quality

2026-01-11 00:39:58 +01:00

zone_test.go

fix: auto-resolve whitespace and formatting issues using golangci-lint --fix

2026-01-09 23:12:08 +01:00

zone.go

Fix golangci-lint findings and improve code quality

2026-01-11 00:39:58 +01:00