Tobias GesellchenandClaude Sonnet 5 28de254f77 fix(datastore): add lock-spanning Mutate helpers for presets/recents/sources ...

GetX-then-SaveX call sites did an unguarded read-modify-write: two
concurrent callers could each read the same starting list, mutate
different entries, and the second writer's Save clobber the first's
update. This is exactly what dropped a preset during #614's rapid-fire
preset-programming repro (overlapping PUT .../preset/N requests).

Add MutatePresets/MutateRecents/MutateConfiguredSources, each holding a
single write lock across the whole read-mutate-write cycle, and switch
resolvePresetSource's auto-add-canonical-source path (the same race,
for sources) to use the new MutateConfiguredSources.

Part of the #614 follow-up; more call sites (UpdatePreset's own preset
write, recents, other sources writers) still need converting.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

2026-08-23 14:08:24 +02:00

..

atomic_write_test.go

fix(datastore): fsync atomicWriteFile for crash-safe durability (#458)

2026-06-04 19:38:12 +02:00

case_sensitivity_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

content_item_case_test.go

fix(datastore): parse legacy <ContentItem> (capital C) in Presets.xml

2026-05-23 13:08:51 +02:00

datastore_test.go

feat(admin): live Settings-page toggle for the opt-in update check

2026-08-10 23:17:36 +02:00

datastore.go

fix(datastore): add lock-spanning Mutate helpers for presets/recents/sources

2026-08-23 14:08:24 +02:00

device_info_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

dns_persistence_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

empty_datastore_test.go

fix(datastore): treat empty/0-byte/unparseable XML as missing → serve defaults (#458)

2026-06-04 19:23:09 +02:00

list_all_devices_default_test.go

fix(datastore): real account wins over "default" placeholder in dedup

2026-05-20 22:41:32 +02:00

logutil.go

fix(security): sec7 — log-injection sweep, sanitizeErr helper

2026-05-25 11:28:26 +02:00

mac_address_serialization_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

mac_first_resolution_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

mac_mapping_diagnostic_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

mapping_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00

presets_ispresetable_test.go

fix(datastore): preserve speaker's isPresetable verdict in SavePresets

2026-05-20 22:30:53 +02:00

presets_regression_test.go

feat(sync): improve parity with upstream during data sync (#123)

2026-03-22 00:01:41 +01:00

recents_dedup_test.go

fix(datastore): dedup recents by ID in SaveRecents (stop same-recent pile-up)

2026-06-14 21:02:24 +02:00

recents_regression_test.go

feat: improve Bose SoundTouch parity, Spotify integration, and data reliability (#138)

2026-04-01 21:55:52 +02:00

repair_leaked_source_test.go

fix(datastore): self-heal legacy Audio leak on read, preserve speaker intent

2026-05-20 22:41:32 +02:00

safe_identifier_test.go

fix(setup): accept non-numeric account IDs reported by third-party pairing tools (#634)

2026-08-22 11:31:08 +02:00

sources_deduction_test.go

refactor(datastore): drop INTERNET_RADIO from initial Sources.xml

2026-05-23 22:45:15 +02:00

sources_regression_test.go

fix(datastore): normalize AUX source to canonical id/type after sync (#233)

2026-05-09 14:16:19 +02:00

upnp_integration_test.go

test: sweep example data in test files to RFC-5737 + placeholders

2026-05-17 22:05:13 +02:00