mirror of
https://github.com/gesellix/Bose-SoundTouch.git
synced 2026-09-07 15:07:17 +00:00
Tobias GesellchenandClaude Sonnet 5
68d8719be0
The exported GetGroup doc comment claimed non-ST10 devices reply to /getGroup "harmlessly" with an empty group. Verified against real hardware this is wrong: a SoundTouch 20 does not reply at all -- the request hangs until the client's own timeout (10-30s depending on how the Client was constructed) instead of returning quickly. Confirmed by direct request against a real ST20 (curl, 8s timeout, zero bytes back) and cross-checked against two actively-paired real ST10 units, which both replied in ~30-40ms with full group data. This matters beyond prose accuracy: the newer stereoPairCapable gate in websocket.go's UpdateDeviceStatus is load-bearing, not an optimization. A future contributor trusting the old (wrong, and more prominent/exported) doc could reasonably "simplify" by removing that gate, reintroducing a 10-30s hang on every poll cycle for every SoundTouch 20/30 on the network. Rewrote the doc to state the real behavior and point at the gate that depends on it; the websocket.go comment now defers to this doc instead of independently (and incorrectly worded) restating it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>