mirror of
https://github.com/gesellix/Bose-SoundTouch.git
synced 2026-08-18 16:46:17 +00:00
- Use package-level variables instead of mixed return/ignore pattern - Call updateBuildInfo() once at startup instead of multiple function calls - Cleaner, more consistent design with single responsibility - Eliminates confusing 'version, _, _' usage pattern Thanks for the excellent code review feedback!
161 lines
4.1 KiB
Go
161 lines
4.1 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"runtime"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/gesellix/bose-soundtouch/pkg/client"
|
|
"github.com/gesellix/bose-soundtouch/pkg/config"
|
|
"github.com/urfave/cli/v2"
|
|
)
|
|
|
|
// CommonFlags defines flags that are shared across multiple commands
|
|
var CommonFlags = []cli.Flag{
|
|
&cli.StringFlag{
|
|
Name: "host",
|
|
Usage: "SoundTouch device host/IP address (can include port like host:8090)",
|
|
EnvVars: []string{"SOUNDTOUCH_HOST"},
|
|
},
|
|
&cli.IntFlag{
|
|
Name: "port",
|
|
Aliases: []string{"p"},
|
|
Usage: "SoundTouch device port",
|
|
Value: 8090,
|
|
EnvVars: []string{"SOUNDTOUCH_PORT"},
|
|
},
|
|
&cli.DurationFlag{
|
|
Name: "timeout",
|
|
Aliases: []string{"t"},
|
|
Usage: "Request timeout",
|
|
Value: 10 * time.Second,
|
|
},
|
|
}
|
|
|
|
// ClientConfig holds configuration for creating a SoundTouch client
|
|
type ClientConfig struct {
|
|
Host string
|
|
Port int
|
|
Timeout time.Duration
|
|
}
|
|
|
|
// GetClientConfig extracts client configuration from CLI context
|
|
func GetClientConfig(c *cli.Context) *ClientConfig {
|
|
host := c.String("host")
|
|
port := c.Int("port")
|
|
timeout := c.Duration("timeout")
|
|
|
|
// Parse host:port if host contains a port
|
|
if host != "" {
|
|
if finalHost, finalPort := parseHostPort(host, port); finalHost != "" {
|
|
host = finalHost
|
|
port = finalPort
|
|
}
|
|
}
|
|
|
|
return &ClientConfig{
|
|
Host: host,
|
|
Port: port,
|
|
Timeout: timeout,
|
|
}
|
|
}
|
|
|
|
// RequireHost validates that a host is provided for commands that need it
|
|
func RequireHost(c *cli.Context) error {
|
|
if c.String("host") == "" {
|
|
return fmt.Errorf("host is required. Use --host flag or set SOUNDTOUCH_HOST environment variable")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// CreateSoundTouchClient creates a configured SoundTouch client
|
|
func CreateSoundTouchClient(config *ClientConfig) (*client.Client, error) {
|
|
cfg, err := loadConfig(config.Timeout)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to load config: %w", err)
|
|
}
|
|
|
|
clientConfig := &client.Config{
|
|
Host: config.Host,
|
|
Port: config.Port,
|
|
Timeout: cfg.HTTPTimeout,
|
|
UserAgent: cfg.UserAgent,
|
|
}
|
|
|
|
return client.NewClient(clientConfig), nil
|
|
}
|
|
|
|
// loadConfig loads the application configuration with optional timeout override
|
|
func loadConfig(timeout time.Duration) (*config.Config, error) {
|
|
cfg, err := config.LoadFromEnv()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Override timeout if provided
|
|
if timeout > 0 {
|
|
cfg.HTTPTimeout = timeout
|
|
}
|
|
|
|
return cfg, nil
|
|
}
|
|
|
|
// parseHostPort splits a host:port string into separate host and port components
|
|
// If no port is specified, returns the original host and the provided default port
|
|
func parseHostPort(hostPort string, defaultPort int) (string, int) {
|
|
// Check if host contains a port (has a colon)
|
|
if strings.Contains(hostPort, ":") {
|
|
host, portStr, err := net.SplitHostPort(hostPort)
|
|
if err != nil {
|
|
// If parsing fails, return original host and default port
|
|
return hostPort, defaultPort
|
|
}
|
|
|
|
port, err := strconv.Atoi(portStr)
|
|
if err != nil || port < 1 || port > 65535 {
|
|
// If port parsing fails or is invalid, return host and default port
|
|
return host, defaultPort
|
|
}
|
|
|
|
return host, port
|
|
}
|
|
|
|
// No port specified, return original host and default port
|
|
return hostPort, defaultPort
|
|
}
|
|
|
|
// PrintDeviceHeader prints a standard header for device commands
|
|
func PrintDeviceHeader(operation, host string, port int) {
|
|
fmt.Printf("%s from %s:%d...\n", operation, host, port)
|
|
}
|
|
|
|
// PrintSuccess prints a standard success message
|
|
func PrintSuccess(message string) {
|
|
fmt.Printf("✓ %s\n", message)
|
|
}
|
|
|
|
// PrintError prints a standard error message
|
|
func PrintError(message string) {
|
|
fmt.Printf("✗ %s\n", message)
|
|
}
|
|
|
|
// PrintWarning prints a standard warning message
|
|
func PrintWarning(message string) {
|
|
fmt.Printf("⚠️ %s\n", message)
|
|
}
|
|
|
|
// showVersionInfo displays detailed version information including build details
|
|
func showVersionInfo(_ *cli.Context) error {
|
|
fmt.Printf("soundtouch-cli version %s\n", version)
|
|
fmt.Printf("Build commit: %s\n", commit)
|
|
fmt.Printf("Build date: %s\n", date)
|
|
fmt.Printf("Go version: %s\n", runtime.Version())
|
|
fmt.Printf("Platform: %s/%s\n", runtime.GOOS, runtime.GOARCH)
|
|
|
|
return nil
|
|
}
|