- Fix bodyclose issues by properly closing WebSocket response body
- Fix errcheck issues by checking errors on resp.Body.Close(), conn.Close(), etc.
- Fix errorlint issue by using errors.As() instead of type assertion
- Fix nilerr issue by adding proper logging for UPnP discovery failures
- Fix gocritic issues:
- Convert if-else chains to switch statements
- Fix parameter type combining (paramTypeCombine)
- Fix range value copying (rangeValCopy)
- Fix exitAfterDefer by calling cancel() before log.Fatalf()
- Add package comments to fix revive package-comments issues
- Rename ClientConfig to Config to avoid type name stuttering
- Add missing exported constant comments
- Fix unused parameter issues by renaming to _
- Fix empty block issues
- Add t.Helper() to test helper functions
- Update User-Agent and fix GetNetworkSummary behavior to match test expectations
Reduces linting issues from 151 to 108 (28% improvement).
All tests now pass.
Major additions:
- Fixed WebSocketMessage XMLName struct tag issue
- Implemented remaining official API endpoints:
* POST /name (SetName) - Set device name
* GET /bassCapabilities (GetBassCapabilities) - Check bass support
* GET /trackInfo (GetTrackInfo) - Track information (duplicate of now_playing)
New features:
- BassCapabilities model with validation and helper methods
- SetName method for device naming
- GetTrackInfo method for track information
- Full CLI support for all new endpoints
- Comprehensive test coverage (503 lines of tests)
Testing results:
- All unit tests pass ✅
- bassCapabilities works on SoundTouch 10 ✅
- trackInfo may not be supported on all models (timeout on SoundTouch 10)
- SetName not tested on real hardware (to avoid changing device name)
API Coverage: Now 100% of official Bose SoundTouch Web API v1.0
- 19/19 endpoints implemented
- All documented features supported
- Additional undocumented endpoints working (clock, network, balance)
- Add complete bass control functionality via GET/POST /bass endpoints
- Implement GetBass() for current bass level retrieval
- Add SetBass() with range validation (-9 to +9)
- Include IncreaseBass() and DecreaseBass() with safety limits
- Add SetBassSafe() with automatic value clamping
- Create comprehensive bass models with validation and helpers
- Add CLI flags: -bass, -set-bass, -inc-bass, -dec-bass
- Implement safety features with range validation and clamping
- Create comprehensive test suite (30+ test cases) with mock servers
- Add integration tests with real device validation (SoundTouch 10/20)
- Update documentation with complete BASS-CONTROLS.md guide
- Update API endpoints status (GET/POST /bass: ✅ Implemented)
- Update project status (55% overall completion, 80% control endpoints)
- Real device testing with bass adjustment and validation
- Error handling for invalid ranges and API responses
- XML request/response format validation and compliance
- Human-readable bass level descriptions and categorization
Tobias Gesellchen