github/Bose-SoundTouch
1
0
Fork 0
mirror of https://github.com/gesellix/Bose-SoundTouch.git synced 2026-08-18 16:46:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve unused parameter (revive) issues

Browse Source 
- Fixed multiple unused parameter warnings in test files
- Renamed unused HTTP request parameters to underscore (_) in test handlers
- Fixed unused parameters in client_test.go, system_test.go, source_selection_test.go, websocket_test.go

Progress: Reduced total issues from 27 to 25 (7% improvement)
Remaining issues:
- gocyclo: 14 (complexity - requires manual refactoring)
- revive: 3 (style/naming - mostly the discovery service naming)
- staticcheck: 5 (static analysis)
- unparam: 3 (unused parameters - mostly test utilities)
This commit is contained in:
Tobias Gesellchen
2026-01-09 23:14:45 +01:00
parent 6f27a559e4
commit 9ce5948eae
4 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/client/client_test.go
+11 -11
View File
@@ -159,7 +159,7 @@ func TestGetDeviceInfo_Success(t *testing.T) {
func TestGetDeviceInfo_HTTPError(t *testing.T) {
// Create mock server that returns 404
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusNotFound)
_, _ = w.Write([]byte("Not Found"))
}))
@@ -181,7 +181,7 @@ func TestGetDeviceInfo_HTTPError(t *testing.T) {
func TestGetDeviceInfo_InvalidXML(t *testing.T) {
// Create mock server that returns invalid XML
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Content-Type", "application/xml")
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte("invalid xml content"))
@@ -204,7 +204,7 @@ func TestGetDeviceInfo_InvalidXML(t *testing.T) {
func TestGetDeviceInfo_APIError(t *testing.T) {
// Create mock server that returns API error
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Content-Type", "application/xml")
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`<?xml version="1.0" encoding="UTF-8"?><error code="404">Device not found</error>`))
@@ -228,7 +228,7 @@ func TestGetDeviceInfo_APIError(t *testing.T) {
func TestPing_Success(t *testing.T) {
testData := loadTestData(t, "info_response.xml")
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Content-Type", "application/xml")
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(testData))
@@ -244,7 +244,7 @@ func TestPing_Success(t *testing.T) {
}
func TestPing_Failure(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusInternalServerError)
}))
defer server.Close()
@@ -268,7 +268,7 @@ func TestBaseURL(t *testing.T) {
func TestClientTimeout(t *testing.T) {
// Create a server that delays response
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
time.Sleep(200 * time.Millisecond)
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`<info deviceID="test"></info>`))
@@ -419,7 +419,7 @@ func TestClient_GetNowPlaying(t *testing.T) {
}
func TestClient_GetNowPlaying_ServerError(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusInternalServerError)
_, _ = w.Write([]byte("Internal Server Error"))
}))
@@ -465,7 +465,7 @@ func TestClient_GetNowPlaying_NetworkError(t *testing.T) {
}
func TestClient_GetNowPlaying_InvalidXML(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Content-Type", "application/xml")
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte("<invalid-xml>"))
@@ -608,7 +608,7 @@ func TestClient_GetSources(t *testing.T) {
}
func TestClient_GetSources_ServerError(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusInternalServerError)
_, _ = w.Write([]byte("Internal Server Error"))
}))
@@ -654,7 +654,7 @@ func TestClient_GetSources_NetworkError(t *testing.T) {
}
func TestClient_GetSources_InvalidXML(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Content-Type", "application/xml")
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte("<invalid-xml>"))
@@ -959,7 +959,7 @@ func TestClient_GetPresets(t *testing.T) {
}
func TestClient_GetName_ServerError(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusInternalServerError)
_, _ = w.Write([]byte("Internal Server Error"))
}))
pkg/client/source_selection_test.go
+3 -3
View File
@@ -396,7 +396,7 @@ func TestClient_SelectSource_ErrorHandling(t *testing.T) {
}{
{
name: "Server returns 404",
serverResponse: func(w http.ResponseWriter, r *http.Request) {
serverResponse: func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusNotFound)
_, _ = w.Write([]byte("Not Found"))
},
@@ -405,7 +405,7 @@ func TestClient_SelectSource_ErrorHandling(t *testing.T) {
},
{
name: "Server returns 500",
serverResponse: func(w http.ResponseWriter, r *http.Request) {
serverResponse: func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusInternalServerError)
_, _ = w.Write([]byte("Internal Server Error"))
},
@@ -414,7 +414,7 @@ func TestClient_SelectSource_ErrorHandling(t *testing.T) {
},
{
name: "Server returns API error",
serverResponse: func(w http.ResponseWriter, r *http.Request) {
serverResponse: func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusBadRequest)
apiError := models.APIError{
pkg/client/system_test.go
+1 -1
View File
@@ -351,7 +351,7 @@ func TestClient_EnableDisableClockDisplay(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusOK)
}))
defer server.Close()
pkg/client/websocket_test.go
+1 -1
View File
@@ -494,7 +494,7 @@ func BenchmarkWebSocketClient_SetHandlers(b *testing.B) {
handlers := &models.WebSocketEventHandlers{
OnNowPlaying: func(_ *models.NowPlayingUpdatedEvent) {},
OnVolumeUpdated: func(event *models.VolumeUpdatedEvent) {},
OnVolumeUpdated: func(_ *models.VolumeUpdatedEvent) {},
}
b.ResetTimer()