From 5d2f5d12ecb7584a3254cb8aa01634ccb2ad2e1b Mon Sep 17 00:00:00 2001 From: Marcin Mennemann Date: Sat, 16 May 2026 00:23:55 +0200 Subject: [PATCH] fix: detect telnet-only migrations in summary by waiting for probe result --- pkg/service/setup/setup.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/service/setup/setup.go b/pkg/service/setup/setup.go index 32ccaa2..6c9658e 100644 --- a/pkg/service/setup/setup.go +++ b/pkg/service/setup/setup.go @@ -329,10 +329,6 @@ func (m *Manager) GetMigrationSummary(deviceIP, targetURL, proxyURL string, opti // 3. Provide HTTPS URL for testing (consumed by the migration UI) summary.ServerHTTPSURL = m.buildServerHTTPSURL(targetURL) - // 4. Check if migrated (telnet axis uses the parallel preflight; - // XML/hosts/resolv axes use the probe data already gathered above). - m.checkIsMigratedFromProbe(summary, probe) - // 7. Mirroring settings if m.DataStore != nil { settings, err := m.DataStore.GetSettings() @@ -351,6 +347,11 @@ func (m *Manager) GetMigrationSummary(deviceIP, targetURL, proxyURL string, opti summary.TelnetVerifiedConfig = telnetResult.TelnetVerifiedConfig summary.TelnetProbeError = telnetResult.TelnetProbeError + // 4. Check if migrated (must run after telnet results are merged so + // TelnetVerifiedConfig is populated). XML/hosts/resolv axes use the + // probe data already gathered above. + m.checkIsMigratedFromProbe(summary, probe) + // 9. Cross-check SSH-XML and telnet-getpdo readings; surface any // divergence as a non-fatal warning. m.crossCheckPreflights(summary)