From 4799eab7e5974614d7a4243c7d3b68b0d30c5eda Mon Sep 17 00:00:00 2001 From: Tobias Gesellchen Date: Mon, 25 May 2026 21:19:33 +0200 Subject: [PATCH] fix(test): skip TestRadioBrowserSearch_Real unless RADIOBROWSER_INTEGRATION=1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test dials all.api.radio-browser.info directly. When the upstream TLS certificate expires the test fails and blocks the build — the local codebase has no control over third-party certificate health. Guard with testing.Short() and an opt-in env var so CI stays green and the live-network test can still be run explicitly when needed. Closes #412 Co-Authored-By: Claude Sonnet 4.6 --- pkg/service/bmx/radiobrowser_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/service/bmx/radiobrowser_test.go b/pkg/service/bmx/radiobrowser_test.go index d70a0c3..9212fe8 100644 --- a/pkg/service/bmx/radiobrowser_test.go +++ b/pkg/service/bmx/radiobrowser_test.go @@ -4,6 +4,7 @@ import ( "fmt" "net/http" "net/http/httptest" + "os" "testing" ) @@ -44,6 +45,9 @@ func TestRadioBrowserSearch(t *testing.T) { } func TestRadioBrowserSearch_Real(t *testing.T) { + if testing.Short() || os.Getenv("RADIOBROWSER_INTEGRATION") == "" { + t.Skip("skipping live network test; set RADIOBROWSER_INTEGRATION=1 to run") + } query := "Deutschlandfunk Kultur" resp, err := RadioBrowserSearch(query) if err != nil {