From 1729fa5d3526be6747435006f551aea678fc5d22 Mon Sep 17 00:00:00 2001 From: Tobias Gesellchen Date: Fri, 9 Jan 2026 23:21:33 +0100 Subject: [PATCH] fix: resolve all staticcheck issues (SA5011) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fixed nil pointer dereference warnings by using t.Fatal instead of t.Error - In unified_test.go: Changed service nil check to use t.Fatal - In clockdisplay_test.go: Changed request nil check to use t.Fatal Using t.Fatal ensures test execution stops if pointer is nil, eliminating possibility of subsequent nil pointer dereference. Progress: Eliminated all 5 staticcheck issues Total issues: 21 → 16 (24% improvement) Remaining: - gocyclo: 14 (complexity - requires refactoring) - revive: 1 (DiscoveryService naming) - unparam: 1 (client.post result parameter) --- pkg/discovery/unified_test.go | 2 +- pkg/models/clockdisplay_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/discovery/unified_test.go b/pkg/discovery/unified_test.go index beafca4..99bf44d 100644 --- a/pkg/discovery/unified_test.go +++ b/pkg/discovery/unified_test.go @@ -13,7 +13,7 @@ func TestNewUnifiedDiscoveryService(t *testing.T) { service := NewUnifiedDiscoveryService(cfg) if service == nil { - t.Error("Expected service to be created, got nil") + t.Fatal("Expected service to be created, got nil") } if service.config != cfg { diff --git a/pkg/models/clockdisplay_test.go b/pkg/models/clockdisplay_test.go index 306b8b3..34c238f 100644 --- a/pkg/models/clockdisplay_test.go +++ b/pkg/models/clockdisplay_test.go @@ -386,7 +386,7 @@ func TestNewClockDisplayRequest(t *testing.T) { request := NewClockDisplayRequest() if request == nil { - t.Error("Expected non-nil request") + t.Fatal("Expected non-nil request") } if request.Enabled != nil {